View Single Post
  #5  
Old 10-12-2024, 02:55
HarrySpoofer HarrySpoofer is offline
Friend
 
Join Date: Jul 2018
Posts: 47
Rept. Given: 0
Rept. Rcvd 5 Times in 3 Posts
Thanks Given: 10
Thanks Rcvd at 50 Times in 19 Posts
HarrySpoofer Reputation: 5
Quote:
Originally Posted by sendersu View Post
@HarrySpoofer
thanks for nice piece of work!

If you don't mind I"d provide some small feedback:

1) I'd do case insensitive comparison inside the GetProcessIdByName() routine
-> if (pe.szExeFile == processName)

2) compiler is unhappy on setting signed int to unsided dword;
warning C4245: 'initializing': conversion from 'int' to 'DWORD', signed/unsigned mismatch

do you know if Windows has got some define for wrong pid values?
eg smth like INVALID_HANDLE_VALUE

3) be honest, did you leave an Easter Egg in one routine?

kudos!
Thank for the feedback.
I made the changes you suggested and updated the attachment and the link.

BTW: I did not put an Easter egg in it, I added new icons, though.

Last edited by HarrySpoofer; 10-12-2024 at 05:34.
Reply With Quote
The Following 4 Users Say Thank You to HarrySpoofer For This Useful Post:
niculaita (10-16-2024), ontryit (12-19-2024), sendersu (10-12-2024), wx69wx2023 (10-12-2024)