Exetools  

Go Back   Exetools > General > Source Code

Notices

 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
  #14  
Old 10-13-2024, 13:34
niculaita's Avatar
niculaita niculaita is offline
Family
 
Join Date: Jun 2011
Location: here
Posts: 1,476
Rept. Given: 1,009
Rept. Rcvd 95 Times in 65 Posts
Thanks Given: 5,431
Thanks Rcvd at 508 Times in 359 Posts
niculaita Reputation: 95
Quote:
Originally Posted by sendersu View Post
I"ve ran the PVS Tool against the tool,
I"d like to note -very well done!

some minor suggestions: https://prnt.sc/vQpQVeHUiyV0

eg:
DWORD GetProcessIdByName(wstring processName)
->
DWORD GetProcessIdByName(const wstring& processName)

and similar ones

2) there are some potential set of handle leaks (not closed)

3) I've commented out this enablement:
//EnablePrivilege(SE_DEBUG_NAME);
and the tool still works?!

4) imagine that some end user is having localized Windows OS, eg chinese or japanese or some arabic, etc
how about supporting these users as well?

IMHO in this case the routine
std::string GetLastErrorAsString()

need to be unicode (wide string) aware
please post upload your compilation cause first one does not work well on my pc with win 11 pro 23h2
__________________
Decode and Conquer
Reply With Quote
 

Tags
context menu, source, trusted installer

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Disabled (ungrayed) Menu ivanov General Discussion 13 06-21-2005 15:05
BP to find the SAVE AS menu Gato_negro General Discussion 9 04-09-2005 02:39


All times are GMT +8. The time now is 04:31.


Always Your Best Friend: Aaron, JMI, ahmadmansoor, ZeNiX, chessgod101
( Since 1998 )