hashcat and HMAC-SHA256 ...

[chants]

The First/Next change:... is a mistake I meant to say it is easiest to change:

https://github.com/hashcat/hashcat/blob/master/include/common.h

#define SALT_MAX            256
#define SALT_MAX_OLD        51

So SALT_MAX could be 8192 although it will affect many other constructs.

Either way I have no forward and back traced this issue - and I am guessing you changed SALT_MAX (it looks like for whatever reason PW_MAX is not used in 1450, not sure why). But you probably forgot to change the pw_t structure size.

If either PW_MAX or SALT_MAX is increased about 256, the pw_t->i member needs its array size increased to max(SALT_MAX, PW_MAX)/sizeof(u32) which is currently correctly set to its corresponding 256/4=64 value. Probably why the comment "// do not try to simply change this, it will not work" is sitting right above those constants. Too bad that macro is no easy to integrate in the source due to that file being dependency free.

Also please take note:

#define RP_PASSWORD_SIZE  256

In the following 2 files though I am not sure which rules exactly if any are applied to the password in this case.

https://github.com/hashcat/hashcat/blob/master/OpenCL/inc_rp.h
https://github.com/hashcat/hashcat/blob/master/include/rp.h