Exetools  

Go Back   Exetools > General > Source Code

Notices

 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
  #13  
Old 10-12-2024, 17:35
sendersu sendersu is offline
VIP
 
Join Date: Oct 2010
Posts: 1,305
Rept. Given: 337
Rept. Rcvd 237 Times in 127 Posts
Thanks Given: 340
Thanks Rcvd at 652 Times in 357 Posts
sendersu Reputation: 200-299 sendersu Reputation: 200-299 sendersu Reputation: 200-299
I"ve ran the PVS Tool against the tool,
I"d like to note -very well done!

some minor suggestions: https://prnt.sc/vQpQVeHUiyV0

eg:
DWORD GetProcessIdByName(wstring processName)
->
DWORD GetProcessIdByName(const wstring& processName)

and similar ones

2) there are some potential set of handle leaks (not closed)

3) I've commented out this enablement:
//EnablePrivilege(SE_DEBUG_NAME);
and the tool still works?!

4) imagine that some end user is having localized Windows OS, eg chinese or japanese or some arabic, etc
how about supporting these users as well?

IMHO in this case the routine
std::string GetLastErrorAsString()

need to be unicode (wide string) aware

Last edited by sendersu; 10-12-2024 at 17:42.
Reply With Quote
The Following 2 Users Say Thank You to sendersu For This Useful Post:
HarrySpoofer (11-02-2024), niculaita (10-13-2024)
 

Tags
context menu, source, trusted installer


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is On


Similar Threads
Thread Thread Starter Forum Replies Last Post
Disabled (ungrayed) Menu ivanov General Discussion 13 06-21-2005 15:05
BP to find the SAVE AS menu Gato_negro General Discussion 9 04-09-2005 02:39


All times are GMT +8. The time now is 23:54.


Always Your Best Friend: Aaron, JMI, ahmadmansoor, ZeNiX, chessgod101
( Since 1998 )