![]() |
|
#13
|
|||
|
|||
|
I"ve ran the PVS Tool against the tool,
I"d like to note -very well done! some minor suggestions: https://prnt.sc/vQpQVeHUiyV0 eg: DWORD GetProcessIdByName(wstring processName) -> DWORD GetProcessIdByName(const wstring& processName) and similar ones 2) there are some potential set of handle leaks (not closed) 3) I've commented out this enablement: //EnablePrivilege(SE_DEBUG_NAME); and the tool still works?! 4) imagine that some end user is having localized Windows OS, eg chinese or japanese or some arabic, etc how about supporting these users as well? IMHO in this case the routine std::string GetLastErrorAsString() need to be unicode (wide string) aware Last edited by sendersu; 10-12-2024 at 17:42. |
| The Following 2 Users Say Thank You to sendersu For This Useful Post: | ||
HarrySpoofer (11-02-2024), niculaita (10-13-2024) | ||
| Tags |
| context menu, source, trusted installer |
|
|
Similar Threads
|
||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| Disabled (ungrayed) Menu | ivanov | General Discussion | 13 | 06-21-2005 15:05 |
| BP to find the SAVE AS menu | Gato_negro | General Discussion | 9 | 04-09-2005 02:39 |