Exetools  

Go Back   Exetools > General > General Discussion

Notices

Reply
 
Thread Tools Display Modes
  #1  
Old 08-19-2019, 08:20
chants chants is offline
VIP
 
Join Date: Jul 2016
Posts: 826
Rept. Given: 47
Rept. Rcvd 50 Times in 31 Posts
Thanks Given: 737
Thanks Rcvd at 1,140 Times in 529 Posts
chants Reputation: 51
The First/Next change:... is a mistake I meant to say it is easiest to change:
Quote:
https://github.com/hashcat/hashcat/blob/master/include/common.h
Code:
#define SALT_MAX            256
#define SALT_MAX_OLD        51
So SALT_MAX could be 8192 although it will affect many other constructs.

Either way I have no forward and back traced this issue - and I am guessing you changed SALT_MAX (it looks like for whatever reason PW_MAX is not used in 1450, not sure why). But you probably forgot to change the pw_t structure size.

If either PW_MAX or SALT_MAX is increased about 256, the pw_t->i member needs its array size increased to max(SALT_MAX, PW_MAX)/sizeof(u32) which is currently correctly set to its corresponding 256/4=64 value. Probably why the comment "// do not try to simply change this, it will not work" is sitting right above those constants. Too bad that macro is no easy to integrate in the source due to that file being dependency free.

Also please take note:
Code:
#define RP_PASSWORD_SIZE  256
In the following 2 files though I am not sure which rules exactly if any are applied to the password in this case.
Quote:
https://github.com/hashcat/hashcat/blob/master/OpenCL/inc_rp.h
https://github.com/hashcat/hashcat/blob/master/include/rp.h

Last edited by chants; 08-19-2019 at 08:31.
Reply With Quote
  #2  
Old 08-21-2019, 21:31
debugasm debugasm is offline
Friend
 
Join Date: Oct 2017
Posts: 14
Rept. Given: 0
Rept. Rcvd 1 Time in 1 Post
Thanks Given: 11
Thanks Rcvd at 38 Times in 8 Posts
debugasm Reputation: 1
Thumbs up

Thanks chants,

the change I made was just this:

Code:
#define SALT_MAX            8192
as you had recommended too.

There are other calculations, looking in the chain of routines, which should be adjusted, but you risk doing only damage. The author should have put his hands in it, but I doubt he has the time and the will to do it.

I'll do some more tests.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



All times are GMT +8. The time now is 20:06.


Always Your Best Friend: Aaron, JMI, ahmadmansoor, ZeNiX, chessgod101
( Since 1998 )